implemented feedback

testcontainers · Feb 12, 2017 · 9cefeb7 · 9cefeb7
1 parent c2c6576
commit 9cefeb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/core/src/main/java/org/testcontainers/containers/Container.java b/core/src/main/java/org/testcontainers/containers/Container.java
@@ -132,11 +132,11 @@ public String getStderr() {
     /**
      * Adds container volumes.
      *
-     * @param otherContainer the other container object to add volumes from
+     * @param container the container to add volumes from
      * @param mode the bind mode
      * @return this
      */
-    SELF withVolumesFrom(String otherContainer, BindMode mode);
+    SELF withVolumesFrom(Container container, BindMode mode);
 
     /**
      * Set the ports that this container listens on

diff --git a/core/src/main/java/org/testcontainers/containers/GenericContainer.java b/core/src/main/java/org/testcontainers/containers/GenericContainer.java
@@ -505,13 +505,13 @@ public SELF withFileSystemBind(String hostPath, String containerPath, BindMode m
      * {@inheritDoc}
      */
     @Override
-    public SELF withVolumesFrom(String otherContainer, BindMode mode) {
-        addVolumesFrom(otherContainer, mode);
+    public SELF withVolumesFrom(Container container, BindMode mode) {
+        addVolumesFrom(container, mode);
         return self();
     }
 
-    private void addVolumesFrom(String otherContainer, BindMode mode) {
-        volumesFroms.add(new VolumesFrom(otherContainer, mode.accessMode));
+    private void addVolumesFrom(Container container, BindMode mode) {
+        volumesFroms.add(new VolumesFrom(container.getContainerName(), mode.accessMode));
     }
 
     @Override