Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
tgeens committed Oct 20, 2023
1 parent 5c8138d commit a160c79
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public class Fabric8K3sContainerTest {

@Test
public void shouldStartAndHaveListableNode() {
runK3s(DockerImageName.parse("rancher/k3s:v1.21.3-k3s1"));
}

@Test
public void shouldStartAndHaveListableNode_backwardsCompat() {
runK3s(DockerImageName.parse("rancher/k3s:v1.17.17-k3s1"));
}

private void runK3s(DockerImageName k3sDockerImage) {
try (
// starting_k3s {
K3sContainer k3s = new K3sContainer(k3sDockerImage)
K3sContainer k3s = new K3sContainer(DockerImageName.parse("rancher/k3s:v1.21.3-k3s1"))
.withLogConsumer(new Slf4jLogConsumer(log))
// }
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void shouldStartAndHaveListableNode() throws IOException, ApiException {
}

@Test
public void shouldStartAndHaveListableNode_backwardsCompat() throws IOException, ApiException {
public void shouldStartAndHaveListableNodeUsingLowerVersion() throws IOException, ApiException {
runK3s(DockerImageName.parse("rancher/k3s:v1.17.17-k3s1"));
}

Expand Down

0 comments on commit a160c79

Please sign in to comment.