Add proper test scope to Vibur and Tomcat-JDBC dependencies used fo…

…r testing (#382) * Add proper `test` scope to Vibur and Tomcat-JDBC dependencies used for testing * Update changelog * Update CHANGELOG.md
testcontainers · Jun 28, 2017 · b98af3f · b98af3f
1 parent 302fa39
commit b98af3f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
 ### Fixed
 - Fixed the case when disk's size is bigger than Integer's max value (#379, #380)
 - Fix erroneous version reference used during CI testing of shaded dependencies
+- Fix leakage of Vibur and Tomcat JDBC test dependencies in `jdbc-test` and `mysql` modules (#382)
 
 ### Changed
 - Added support for Docker networks (#372)

diff --git a/modules/jdbc-test/pom.xml b/modules/jdbc-test/pom.xml
@@ -63,11 +63,13 @@
             <groupId>org.apache.tomcat</groupId>
             <artifactId>tomcat-jdbc</artifactId>
             <version>8.5.4</version>
+            <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.vibur</groupId>
             <artifactId>vibur-dbcp</artifactId>
             <version>9.0</version>
+            <scope>test</scope>
         </dependency>
 
         <dependency>

diff --git a/modules/mysql/pom.xml b/modules/mysql/pom.xml
@@ -49,11 +49,13 @@
             <groupId>org.apache.tomcat</groupId>
             <artifactId>tomcat-jdbc</artifactId>
             <version>8.5.4</version>
+            <scope>test</scope>
         </dependency>
         <dependency>
           <groupId>org.vibur</groupId>
           <artifactId>vibur-dbcp</artifactId>
           <version>9.0</version>
+            <scope>test</scope>
         </dependency>
     </dependencies>
 </project>