Remove unnecessary public access modifiers from junit5 tests

testcontainers · Aug 24, 2023 · bad1441 · bad1441
1 parent ceb3e68
commit bad1441
Show file tree

Hide file tree

Showing 13 changed files with 41 additions and 41 deletions.
diff --git a/examples/hazelcast/src/test/java/org/testcontainers/examples/HazelcastTest.java b/examples/hazelcast/src/test/java/org/testcontainers/examples/HazelcastTest.java
@@ -18,7 +18,7 @@
 /**
  * Examples with Hazelcast using both a single container and a cluster with two containers.
  */
-public class HazelcastTest {
+class HazelcastTest {
 
     // Hazelcast values
     private static final String HZ_IMAGE_NAME = "hazelcast/hazelcast:5.2.0";
@@ -47,12 +47,12 @@ public class HazelcastTest {
     private static final String TRUE_VALUE = "true";
 
     @AfterEach
-    public void cleanUp() {
+    void cleanUp() {
         HazelcastClient.shutdownAll();
     }
 
     @Test
-    public void singleHazelcastContainer() {
+    void singleHazelcastContainer() {
         try (
             GenericContainer<?> container = new GenericContainer<>(DockerImageName.parse(HZ_IMAGE_NAME))
                 .withExposedPorts(DEFAULT_EXPOSED_PORT)
@@ -76,7 +76,7 @@ public void singleHazelcastContainer() {
     }
 
     @Test
-    public void hazelcastCluster() {
+    void hazelcastCluster() {
         Network network = Network.newNetwork();
         try (
             GenericContainer<?> container1 = new GenericContainer<>(DockerImageName.parse(HZ_IMAGE_NAME))

diff --git a/examples/immudb/src/test/java/ImmuDbTest.java b/examples/immudb/src/test/java/ImmuDbTest.java
@@ -16,7 +16,7 @@
  * Test class for the ImmuDbClient.
  */
 @Testcontainers
-public class ImmuDbTest {
+class ImmuDbTest {
 
     // Default port for the ImmuDb server
     private static final int IMMUDB_PORT = 3322;
@@ -40,7 +40,7 @@ public class ImmuDbTest {
     private ImmuClient immuClient;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         this.immuClient =
             ImmuClient
                 .newBuilder()
@@ -51,12 +51,12 @@ public void setUp() {
     }
 
     @AfterEach
-    public void tearDown() {
+    void tearDown() {
         this.immuClient.closeSession();
     }
 
     @Test
-    public void testGetValue() {
+    void testGetValue() {
         try {
             immuClient.set("test1", "test2".getBytes());
 

diff --git a/examples/kafka-cluster/src/test/java/com/example/kafkacluster/KafkaContainerClusterTest.java b/examples/kafka-cluster/src/test/java/com/example/kafkacluster/KafkaContainerClusterTest.java
@@ -25,10 +25,10 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
 
-public class KafkaContainerClusterTest {
+class KafkaContainerClusterTest {
 
     @Test
-    public void testKafkaContainerCluster() throws Exception {
+    void testKafkaContainerCluster() throws Exception {
         try (KafkaContainerCluster cluster = new KafkaContainerCluster("6.2.1", 3, 2)) {
             cluster.start();
             String bootstrapServers = cluster.getBootstrapServers();
@@ -40,7 +40,7 @@ public void testKafkaContainerCluster() throws Exception {
     }
 
     @Test
-    public void testKafkaContainerKraftCluster() throws Exception {
+    void testKafkaContainerKraftCluster() throws Exception {
         try (KafkaContainerKraftCluster cluster = new KafkaContainerKraftCluster("7.0.0", 3, 2)) {
             cluster.start();
             String bootstrapServers = cluster.getBootstrapServers();
@@ -52,7 +52,7 @@ public void testKafkaContainerKraftCluster() throws Exception {
     }
 
     @Test
-    public void testKafkaContainerKraftClusterAfterConfluentPlatform740() throws Exception {
+    void testKafkaContainerKraftClusterAfterConfluentPlatform740() throws Exception {
         try (KafkaContainerKraftCluster cluster = new KafkaContainerKraftCluster("7.4.0", 3, 2)) {
             cluster.start();
             String bootstrapServers = cluster.getBootstrapServers();

diff --git a/examples/nats/src/test/java/com/example/NatsContainerTest.java b/examples/nats/src/test/java/com/example/NatsContainerTest.java
@@ -15,14 +15,14 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class NatsContainerTest {
+class NatsContainerTest {
 
     public static final Integer NATS_PORT = 4222;
 
     public static final Integer NATS_MGMT_PORT = 8222;
 
     @Test
-    public void test() throws IOException, InterruptedException {
+    void test() throws IOException, InterruptedException {
         try (
             GenericContainer<?> nats = new GenericContainer<>("nats:2.9.8-alpine3.16")
                 .withExposedPorts(NATS_PORT, NATS_MGMT_PORT)
@@ -38,7 +38,7 @@ public void test() throws IOException, InterruptedException {
     }
 
     @Test
-    public void testServerStatus() throws IOException {
+    void testServerStatus() throws IOException {
         try (
             GenericContainer<?> nats = new GenericContainer<>("nats:2.9.8-alpine3.16")
                 .withExposedPorts(NATS_PORT, NATS_MGMT_PORT)

diff --git a/examples/redis-backed-cache/src/test/java/RedisBackedCacheTest.java b/examples/redis-backed-cache/src/test/java/RedisBackedCacheTest.java
@@ -16,7 +16,7 @@
  * Integration test for Redis-backed cache implementation.
  */
 @Testcontainers
-public class RedisBackedCacheTest {
+class RedisBackedCacheTest {
 
     @Container
     public GenericContainer<?> redis = new GenericContainer<>(DockerImageName.parse("redis:3.0.6"))
@@ -25,14 +25,14 @@ public class RedisBackedCacheTest {
     private Cache cache;
 
     @BeforeEach
-    public void setUp() throws Exception {
+    void setUp() throws Exception {
         Jedis jedis = new Jedis(redis.getHost(), redis.getMappedPort(6379));
 
         cache = new RedisBackedCache(jedis, "test");
     }
 
     @Test
-    public void testFindingAnInsertedValue() {
+    void testFindingAnInsertedValue() {
         cache.put("foo", "FOO");
         Optional<String> foundObject = cache.get("foo", String.class);
 
@@ -43,7 +43,7 @@ public void testFindingAnInsertedValue() {
     }
 
     @Test
-    public void testNotFindingAValueThatWasNotInserted() {
+    void testNotFindingAValueThatWasNotInserted() {
         Optional<String> foundObject = cache.get("bar", String.class);
 
         assertThat(foundObject.isPresent())

diff --git a/examples/selenium-container/src/test/java/SeleniumContainerTest.java b/examples/selenium-container/src/test/java/SeleniumContainerTest.java
@@ -31,7 +31,7 @@
 @ExtendWith(SpringExtension.class)
 @SpringBootTest(classes = DemoApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
 @ContextConfiguration(initializers = SeleniumContainerTest.Initializer.class)
-public class SeleniumContainerTest {
+class SeleniumContainerTest {
 
     @LocalServerPort
     private int port;
@@ -42,7 +42,7 @@ public class SeleniumContainerTest {
         .withRecordingMode(VncRecordingMode.RECORD_ALL, new File("build"));
 
     @Test
-    public void simplePlainSeleniumTest() {
+    void simplePlainSeleniumTest() {
         RemoteWebDriver driver = new RemoteWebDriver(chrome.getSeleniumAddress(), new ChromeOptions());
         driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(30));
 
@@ -52,7 +52,7 @@ public void simplePlainSeleniumTest() {
         assertThat(hElement).as("The h element is found").isNotEmpty();
     }
 
-    public static class Initializer implements ApplicationContextInitializer<ConfigurableApplicationContext> {
+    static class Initializer implements ApplicationContextInitializer<ConfigurableApplicationContext> {
 
         @Override
         public void initialize(ConfigurableApplicationContext applicationContext) {

diff --git a/examples/sftp/src/test/java/org/example/SftpContainerTest.java b/examples/sftp/src/test/java/org/example/SftpContainerTest.java
@@ -14,10 +14,10 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class SftpContainerTest {
+class SftpContainerTest {
 
     @Test
-    public void test() throws Exception {
+    void test() throws Exception {
         try (
             GenericContainer<?> sftp = new GenericContainer<>("atmoz/sftp:alpine-3.7")
                 .withCopyFileToContainer(

diff --git a/examples/singleton-container/src/test/java/com/example/BarConcreteTestClass.java b/examples/singleton-container/src/test/java/com/example/BarConcreteTestClass.java
@@ -10,19 +10,19 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class BarConcreteTestClass extends AbstractIntegrationTest {
+class BarConcreteTestClass extends AbstractIntegrationTest {
 
     private Cache cache;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         Jedis jedis = new Jedis(redis.getHost(), redis.getMappedPort(6379));
 
         cache = new RedisBackedCache(jedis, "bar");
     }
 
     @Test
-    public void testInsertValue() {
+    void testInsertValue() {
         cache.put("bar", "BAR");
         Optional<String> foundObject = cache.get("bar", String.class);
 

diff --git a/examples/singleton-container/src/test/java/com/example/FooConcreteTestClass.java b/examples/singleton-container/src/test/java/com/example/FooConcreteTestClass.java
@@ -10,19 +10,19 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class FooConcreteTestClass extends AbstractIntegrationTest {
+class FooConcreteTestClass extends AbstractIntegrationTest {
 
     private Cache cache;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         Jedis jedis = new Jedis(redis.getHost(), redis.getMappedPort(6379));
 
         cache = new RedisBackedCache(jedis, "foo");
     }
 
     @Test
-    public void testInsertValue() {
+    void testInsertValue() {
         cache.put("foo", "FOO");
         Optional<String> foundObject = cache.get("foo", String.class);
 

diff --git a/examples/solr-container/src/test/java/com/example/SolrQueryTest.java b/examples/solr-container/src/test/java/com/example/SolrQueryTest.java
@@ -17,7 +17,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class SolrQueryTest {
+class SolrQueryTest {
 
     private static final DockerImageName SOLR_IMAGE = DockerImageName.parse("solr:8.3.0");
 
@@ -27,7 +27,7 @@ public class SolrQueryTest {
     private static SolrClient solrClient;
 
     @BeforeAll
-    public static void setUp() throws IOException, SolrServerException {
+    static void setUp() throws IOException, SolrServerException {
         solrContainer.start();
         solrClient =
             new Http2SolrClient.Builder(
@@ -63,7 +63,7 @@ public static void setUp() throws IOException, SolrServerException {
     }
 
     @Test
-    public void testQueryForShoes() {
+    void testQueryForShoes() {
         SolrSearchEngine searchEngine = new SolrSearchEngine(solrClient);
 
         SearchResult result = searchEngine.search("shoes");
@@ -72,7 +72,7 @@ public void testQueryForShoes() {
     }
 
     @Test
-    public void testQueryForTShirt() {
+    void testQueryForTShirt() {
         SolrSearchEngine searchEngine = new SolrSearchEngine(solrClient);
 
         SearchResult result = searchEngine.search("t-shirt");
@@ -81,7 +81,7 @@ public void testQueryForTShirt() {
     }
 
     @Test
-    public void testQueryForAsterisk() {
+    void testQueryForAsterisk() {
         SolrSearchEngine searchEngine = new SolrSearchEngine(solrClient);
 
         SearchResult result = searchEngine.search("*");

diff --git a/examples/spring-boot/src/test/java/com/example/AbstractIntegrationTest.java b/examples/spring-boot/src/test/java/com/example/AbstractIntegrationTest.java
@@ -17,7 +17,7 @@
     properties = { "spring.datasource.url=jdbc:tc:postgresql:11-alpine:///databasename" }
 )
 @ActiveProfiles("test")
-public abstract class AbstractIntegrationTest {
+abstract class AbstractIntegrationTest {
 
     static GenericContainer<?> redis = new GenericContainer<>(DockerImageName.parse("redis:3-alpine"))
         .withExposedPorts(6379);

diff --git a/examples/spring-boot/src/test/java/com/example/DemoControllerTest.java b/examples/spring-boot/src/test/java/com/example/DemoControllerTest.java
@@ -6,7 +6,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class DemoControllerTest extends AbstractIntegrationTest {
+class DemoControllerTest extends AbstractIntegrationTest {
 
     @Autowired
     TestRestTemplate restTemplate;
@@ -15,7 +15,7 @@ public class DemoControllerTest extends AbstractIntegrationTest {
     DemoRepository demoRepository;
 
     @Test
-    public void simpleTest() {
+    void simpleTest() {
         String fooResource = "/foo";
 
         restTemplate.put(fooResource, "bar");
@@ -24,7 +24,7 @@ public void simpleTest() {
     }
 
     @Test
-    public void simpleJPATest() {
+    void simpleJPATest() {
         DemoEntity demoEntity = new DemoEntity();
         demoEntity.setValue("Some value");
         demoRepository.save(demoEntity);

diff --git a/examples/zookeeper/src/test/java/com/example/ZookeeperContainerTest.java b/examples/zookeeper/src/test/java/com/example/ZookeeperContainerTest.java
@@ -10,12 +10,12 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class ZookeeperContainerTest {
+class ZookeeperContainerTest {
 
     private static final int ZOOKEEPER_PORT = 2181;
 
     @Test
-    public void test() throws Exception {
+    void test() throws Exception {
         String path = "/messages/zk-tc";
         String content = "Running Zookeeper with Testcontainers";
         try (