Skip to content

Commit

Permalink
Adjust wording of pre-flight check messages to be clearer (#457)
Browse files Browse the repository at this point in the history
* Adjust wording of pre-flight check messages to be clearer
when presented as an AssertionError. Replaces #436.

* Update changelog
  • Loading branch information
rnorth committed Sep 18, 2017
1 parent 8eea37c commit d2906fd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
### Changed
- Load `DockerClientProviderStrategy` via Service Loader (#434, #435)
- Make it possible to specify docker compose container in configuration (#422, #425)
- Clarify wording of pre-flight check messages (#457, #436)


## [1.4.2] - 2017-07-25
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public boolean matches(Object o) {

@Override
public void describeTo(Description description) {
description.appendText("is newer than 1.6.0");
description.appendText("should be at least 1.6.0");
}
});
}
Expand All @@ -162,7 +162,7 @@ private void checkDiskSpace(DockerClient dockerClient, String id) {
DiskSpaceUsage df = parseAvailableDiskSpace(outputStream.toString());

VisibleAssertions.assertTrue(
"Docker environment has more than 2GB free",
"Docker environment should have more than 2GB free disk space",
df.availableMB.map(it -> it >= 2048).orElse(true)
);
}
Expand All @@ -187,7 +187,7 @@ private void checkExposedPort(String hostIpAddress, DockerClient dockerClient, S
} catch (IOException e) {
response = e.getMessage();
}
VisibleAssertions.assertEquals("Exposed port is accessible", "hello", response);
VisibleAssertions.assertEquals("A port exposed by a docker container should be accessible", "hello", response);
}

/**
Expand Down

0 comments on commit d2906fd

Please sign in to comment.