Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no need to call toLowerCase() on string parameter of containsSubstringAtOffset(String string, String substring, int offset) #1396

Closed
mumukiller opened this issue Apr 12, 2019 · 1 comment
Closed

There is no need to call toLowerCase() on string parameter of containsSubstringAtOffset(String string, String substring, int offset) #1396

mumukiller opened this issue Apr 12, 2019 · 1 comment
Milestone
1.11.2

Comments

@mumukiller
Copy link
Contributor

mumukiller commented Apr 12, 2019 •
edited

String parameter of containsSubstringAtOffset is always a parsed script content, it's not necessary to call toLowerCase() each time in loop.
It might be done only once before for loop
@mumukiller mumukiller changed the title There is no need to call toLowerCase() on string parameter of containsSubstringAtOffset(String string, String substring, int offset) method There is no need to call toLowerCase() on string parameter of containsSubstringAtOffset(String string, String substring, int offset) Apr 12, 2019
mumukiller pushed a commit to mumukiller/testcontainers-java that referenced this issue Apr 12, 2019
PR testcontainers#1396 There is no need to call toLowerCase() for eac…
0a0efc4 
…h iteration of for loop
@mumukiller mumukiller mentioned this issue Apr 12, 2019
Merged
@rnorth rnorth closed this as completed in e5b629e Apr 13, 2019
@rnorth rnorth added this to the next milestone Apr 15, 2019
@rnorth
Copy link
Member

rnorth commented Apr 16, 2019

Released in 1.11.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.2
Development

No branches or pull requests
2 participants
@rnorth @mumukiller