Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting stack should fail if an DC error occurs #147

Closed
monowai opened this issue May 21, 2016 · 2 comments
Closed

Starting stack should fail if an DC error occurs #147

monowai opened this issue May 21, 2016 · 2 comments
Assignees
@rnorth
Labels
area/docker-compose client/docker-for-mac
Milestone
1.1.0

Comments

@monowai
Copy link

monowai commented May 21, 2016

The DockerComposeContainer continued to try the stack despite a configuration error in the YML. Starting from the command line yielded:
ERROR: Validation failed in file './docker-compose.yml', reason(s)

Can DCC fail the test the test if it encounters such a fatal condition as docker-compose does when starting from the command line?
@rnorth
Copy link
Member

rnorth commented May 21, 2016

Hi
I'm working on this, together with #146, to make some fairly major alterations to the docker compose support. My intention is to fix the currently slightly awkward abstraction of the DockerComposeContainer class being a container object in its own right: really, it should be a class that invokes containerized docker-compose as and when necessary to bring up the environment.

This should open more opportunities for cleaning up the logs output, amongst other improvements.

Richard

rnorth added a commit that referenced this issue May 21, 2016
@rnorth
[WIP] docker compose refactoring, to support scaling, better output l…
bacc5c8 
…ogs, and eventually docker-compose v2 format. Refs #146, #147
@ldcasillas-progreso ldcasillas-progreso mentioned this issue May 27, 2016
Closed
rnorth added a commit that referenced this issue Jun 5, 2016
@rnorth
[WIP] docker compose refactoring, to support scaling, better output l…
a92c8f3 
…ogs, and eventually docker-compose v2 format. Refs #146, #147
rnorth added a commit that referenced this issue Jun 5, 2016
@rnorth
[WIP] docker compose refactoring, to support scaling, better output l…
e78a99f 
…ogs, and eventually docker-compose v2 format. Refs #146, #147
@rnorth
Copy link
Member

rnorth commented Jun 5, 2016

Refactoring continues on branch - still not implemented fail-fast for docker-compose errors yet I'm afraid.

@rnorth rnorth mentioned this issue Jun 5, 2016
Closed
rnorth added a commit that referenced this issue Jun 10, 2016
@rnorth
[WIP] docker compose refactoring, to support scaling, better output l…
14d400a 
…ogs, and eventually docker-compose v2 format. Refs #146, #147
rnorth added a commit that referenced this issue Jul 2, 2016
@rnorth
Add test to make sure that an invalid docker-compose file causes a fa…
5d13fb2 
…ilure (for #147)
@rnorth rnorth self-assigned this Jul 2, 2016
@rnorth rnorth modified the milestone: 1.1.0 Jul 2, 2016
rnorth added a commit that referenced this issue Jul 3, 2016
@rnorth
Add extra debugging logs to help diagnose any future docker daemon co…
fd06344 
…mpatibility issues

Refactor Docker compose support, to allow scaling, better output logs, and eventually docker-compose v2 format. Refs #146, #147

Start support for docker-compose v2 environments, putting ambassador containers onto the right network to be able to access the compose-launched containers.

Fix Netty conflicts by using Jedis for testing (simpler dependencies)
rnorth added a commit that referenced this issue Jul 3, 2016
@rnorth
Add test to make sure that an invalid docker-compose file causes a fa…
6fa9866 
…ilure (for #147)
rnorth added a commit that referenced this issue Jul 3, 2016
@rnorth
Add extra debugging logs to help diagnose any future docker daemon co…
3478853 
…mpatibility issues

Refactor Docker compose support, to allow scaling, better output logs, and eventually docker-compose v2 format. Refs #146, #147

Start support for docker-compose v2 environments, putting ambassador containers onto the right network to be able to access the compose-launched containers.

Fix Netty conflicts by using Jedis for testing (simpler dependencies)
rnorth added a commit that referenced this issue Jul 3, 2016
@rnorth
Add test to make sure that an invalid docker-compose file causes a fa…
f08f887 
…ilure (for #147)
@rnorth rnorth modified the milestone: 1.1.0 Jul 5, 2016
@rnorth rnorth closed this as completed Jul 6, 2016
@wu-sheng wu-sheng mentioned this issue Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnorth rnorth

Labels
area/docker-compose client/docker-for-mac
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@rnorth @monowai