Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerComposeContainer Working Directory #173

Closed
qoomon opened this issue Jul 15, 2016 · 1 comment
Closed

DockerComposeContainer Working Directory #173

qoomon opened this issue Jul 15, 2016 · 1 comment
Milestone

Comments

@qoomon
Copy link
Contributor

qoomon commented Jul 15, 2016

DockerComposeContainer should set working directory for dduportal/docker-compose to folder of given docker-compose-file.

We need this to be able to work with relative path e.g. volumes declaration within docker compose file.

To achieve this you just need to add working directory support to GenericContainer.java, and set working directory within DockerComposeContainer.java

Regards

@rnorth
Copy link
Member

rnorth commented Jul 16, 2016

I think that makes sense to me - can I just check?

  1. Right now Testcontainers is mapping the docker-file's parent directory to /compose while docker-compose is running. However, it is not setting the working directory to /compose.
  2. You'd like to add support for setting the working directory of the container (i.e. The equivalent of the -w or --workdir option for the CLI docker create command)?

If so, that doesn't sound terribly difficult - I can't see any problems with implementing that in the near future.

@rnorth rnorth modified the milestone: 1.1.3 Jul 19, 2016
@rnorth rnorth closed this as completed in e2b61d4 Jul 26, 2016
rnorth added a commit that referenced this issue Jul 26, 2016
Add support for setting working directory - fixes #173
rnorth pushed a commit that referenced this issue Dec 23, 2018
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.7 to 1.7.25.
<details>
<summary>Commits</summary>

- [`a81440e`](qos-ch/slf4j@a81440e) fix date issue in news.html
- [`c2a7cca`](qos-ch/slf4j@c2a7cca) prepare release 1.7.25
- [`a848912`](qos-ch/slf4j@a848912) change serialVersionUID since internals changed
- [`2fc2dc1`](qos-ch/slf4j@2fc2dc1) Merge pull request [#173](https://github-redirect.dependabot.com/qos-ch/slf4j/issues/173) from hazendaz/master
- [`60eb95e`](qos-ch/slf4j@60eb95e) [license] Update copyright year to 2017
- [`2f06933`](qos-ch/slf4j@2f06933) use SLF4J formatter
- [`97472ca`](qos-ch/slf4j@97472ca) fix deprecation issues
- [`4a8c166`](qos-ch/slf4j@4a8c166) fix SLF4J-395
- [`509c344`](qos-ch/slf4j@509c344) fix SLF4J-394
- [`898e222`](qos-ch/slf4j@898e222) type fix
- Additional commits viewable in [compare view](qos-ch/slf4j@v1.7.7...v_1.7.25)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=org.slf4j:slf4j-api&package-manager=maven&previous-version=1.7.7&new-version=1.7.25)](https://dependabot.com/compatibility-score.html?dependency-name=org.slf4j:slf4j-api&package-manager=maven&previous-version=1.7.7&new-version=1.7.25)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants