@Testcontainers is not found in parentclass

[ghost]

i am currently trying to upgrade from testcontainers version 1.11.4 to 1.12.1
it looks there might be an regression between that versions.

our current code (using v 1.11.4 looks like that). It uses an abstract base class that contains the @testcontainers annotation.

@Testcontainers
abstract class MongoTests {
  ...
}

class MongoRepositoryIT(
...
) : MongoTests() {
  ...
}

this setup causes an runtime exception when upgrading to v 1.12.1:

Caused by: org.junit.platform.commons.PreconditionViolationException: Illegal state: required test class is not present in the current ExtensionContext
	at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:281)
	at org.junit.platform.commons.util.Preconditions.notNull(Preconditions.java:54)
	at org.junit.jupiter.api.extension.ExtensionContext.getRequiredTestClass(ExtensionContext.java:141)
	at org.testcontainers.junit.jupiter.TestcontainersExtension.findTestcontainers(TestcontainersExtension.java:62)
	at org.testcontainers.junit.jupiter.TestcontainersExtension.evaluateExecutionCondition(TestcontainersExtension.java:55)
	at org.junit.jupiter.engine.execution.ConditionEvaluator.evaluate(ConditionEvaluator.java:64)
	... 41 more

i can work around that by putting the @testcontainers annotation directly into the concrete test class:

@Testcontainers
class MongoRepositoryIT(...) 

[bsideup]

@abendt-mhp could you please try 1.12.0? I think it may be caused by #1530

[ghost]

sure. its the same exception with v 1.12.0. the workaround also works

[bsideup]

@abendt-mhp thanks!

FYI this task is up for grabs if anyone wants to contribute it :) We will eventually take a look, but would also appreciate a fix contributed.

I confirm that org.testcontainers.junit.jupiter.inheritance.InheritedTests test fails if we remove @Testcontainers annotation from it.

[bmuskalla]

I'd be interested taking this on

[bsideup]

@bmuskalla thanks! It is yours 👍

I will soft timebox it to 7 days, just so that we can check in one week whether you are still working on it :)

[bmuskalla]

@bsideup friendly ping :)

[bsideup]

@bmuskalla thanks for the ping! 👍 there is one trivial thing (codestyle), happy to merge after 🎉

[Nipel-Crumple]

Hello! Could you tell when this PR will be merged approximately?

[christian-draeger]

am waiting for a new release that includes the fix as well :)

[bsideup]

@Nipel-Crumple there is a PR (#1845) from @bmuskalla that waits a bit of polishing before we merge it

[christian-draeger]

is it just because of the star import? i could fix that in case

[bmuskalla]

Sorry, I totally missed the notification on this one. Pushed a new PR (#2001) for this with the imports fixed (and mssed up the old PR)

[bsideup]

@bmuskalla thank you! 👍

[bsideup]

Fixed by #2001