Add support for $HOME/.docker/config.json #247
Milestone
Comments
|
Hi Aboubacar
That seems sensible, thanks for suggesting. If you or anybody else would
like to raise a PR it would be most welcome!
Would it perhaps make sense to check for the existence of the config.json
file and use that first, falling back to dockercfg otherwise? I'd like
Testcontainers to select a sensible default rather than the user having to
inform the tool which file to look at.
Thanks
Richard
…On Fri, 2 Dec 2016 at 19:08 Aboubacar Toure ***@***.***> wrote:
The current version (1.1.7) hardcodes the private registry authentication
file to use ($HOME/.docker/.dockercfg). It would be nice to add support for
$HOME/.docker/config.json.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#247>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIET7Lxx2s06-7U0ZllmcsTxsy4eefFks5rEGyQgaJpZM4LC4jK>
.
|
tourea
added a commit
to tourea/testcontainers-java
that referenced
this issue
Jan 18, 2017
As described in issue 247 ( testcontainers#247), docker-java, up to version 3.0.6, hardcoded the private registry authentication file to use ($HOME/.docker/.dockercfg). I updated docker-java to support both config.json and .dockercfg (docker-java/docker-java#756), which has been released in version 3.0.7. This commit upgrades docker-java's version to 3.0.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current version (1.1.7) hardcodes the private registry authentication file to use ($HOME/.docker/.dockercfg). It would be nice to add support for $HOME/.docker/config.json.
The text was updated successfully, but these errors were encountered: