-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for identitytoken auth type #293
Comments
When I found this issue I was testing on a machine that has a I just tried to reproduce the issue on another machine with the exact same environment. The only difference is that this machine does not have a |
Hi @peter-evans This will probably help reproduce and also identify if there are any edge cases for parsing that need to be handled upstream in docker-java. @tourea might be interested to know about this if there is anything! Richard |
Hi @rnorth This is the file: config.json.txt Except for the following two actions to mask sensitive details everything in the file is unchanged.
There is one entry in the file for a company internal docker registry. All the other entries have presumably been inserted by the Google Cloud SDK. |
I noticed that the entry in the file for my company's internal docker registry is different. It uses Removing that one entry from the file allows the file to be parsed and the spring boot project test passes with version 1.1.9. It seems likely that the parsing code for The product my company is using is the Docker Datacenter. It comes with the Docker Trusted Registry component, which I believe is using the Update: Docker Datacenter has been re-branded Docker Enterprise Edition. |
@peter-evans Sorry for the slow response. We'll need to look into this further. |
@rnorth Yes, I believe that is why version 1.1.7 was working. Before this change docker-java didn't support I think you are right about that AuthConfig DTO. The Docker Trusted Registry, which is a component of the newly branded Docker Enterprise Edition, is the official commercial offering from Docker, so it really should support it. |
I have similar problem - parsing fails when config.json contains "credsStore". There was an issue for this in docker-java (docker-java/docker-java#806) and it's fixed, but new version wasn't released yet. It will be included in docker-java 3.0.12. |
I have the same issue when I try to use version 1.3.1 |
Hi @peter-evans, @mabn, and @email2liyang, we just released 1.4.2, it should fix the issue, could you please try it? Thanks! |
@bsideup , confirmed, it works in v 1.4.2, thanks very much |
Yup, it works |
I tested it but it still doesn't seem to recognise and parse the field
This is the part of the config.json file it doesn't recognise (sensitive info masked):
|
I have the same issue with the unrecognized |
Thanks @Nowheresly - will watch out for that being released. |
@Nowheresly are you aware of reliable workaround, until this issue is fixed in the upstream (other than removing @Rule
public RuleChain chain = RuleChain
.outerRule(new DockerComposeContainer(new File(dockerComposeFile))
.withLocalCompose(true)
.withPull(false)); it is still failing with Should the config be read, if pulling is disabled? |
Hi @majusmisiak , unfortunately, my current workaround consist in remove the identityToken (by calling docker logout). |
Hi @Nowheresly, patching this single class directly solved the problem. I used This seems more portable workaround than removing Many thanks, now awaiting docker-java 3.1.0 release. |
@majusmisiak have you tried running the code from #845 PR? |
@bsideup it will give it a spin locally and add comment on PR if I come up with anything useful for you. |
I think we'll probably need to bump up to docker-java 3.1.0-rc4 to benefit from that PR. I think that would be worth including in #845... |
@rnorth yes, upgrading docker-java is a good idea 👍 |
I agree as well since this bug is really annoying. |
We updated docker-java in #845 on Friday. We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it! |
Fixed with #845. |
Seems to me the support for |
Issue found when attempting to run the test in the spring boot example here:
https://github.com/testcontainers/testcontainers-java-examples/tree/master/spring-boot
Environment
This is the output from executing the maven test phase: build_output.txt
I verified the version by adding the following dependency to the pom.xml
@bsideup identified issue #270 as the possible cause.
After testing with version 1.1.7 the test passed. So it's likely a regression caused by the above issue.
Just an extra detail. After the test passed using version 1.1.7 I recompiled with 1.1.9 and the test passed. I had to manually delete the redis image to cause the error to occur again. So if you already have the required image in your local environment you may need to remove it to reproduce.
The text was updated successfully, but these errors were encountered: