Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest testcontainers version #2

Closed
natevecc opened this issue Mar 14, 2017 · 3 comments · Fixed by #3
Closed

Upgrade to latest testcontainers version #2

natevecc opened this issue Mar 14, 2017 · 3 comments · Fixed by #3

Comments

@natevecc
Copy link
Contributor

The version of testcontainers this is using is behind by a few versions and I'd like to upgrade it to the most recent version. I'll try and do it on my own when I have some free time but any direction and guidance would be really appreciated.

@dimafeng
Copy link
Collaborator

@natevecc Sorry for not updating the version for a while. I'll be able to do it later today.

If you would like to help me with it, you can do the following:

  1. Update the version of TestConteiners in https://github.com/testcontainers/testcontainers-scala/blob/master/gradle.properties
  2. Run ./gradlew clean -Pscala=2.11.8 test integrationTest and ./gradlew clean -Pscala=2.12.1 test integrationTest
  3. if it passes all the tests, I'll be able to release the new version today.

@natevecc
Copy link
Contributor Author

Quick update: tests were initially failing because of this bug which is caused by this. However once I manually pulled the images needed by the tests, commented out the offending config file, then ran the tests everything passed. I'll put up a PR for this soon.

@dimafeng
Copy link
Collaborator

@natevecc thank you for your contribution. I'm going to release the new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants