Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make browser container startup timeout configurable #326

Closed
pavelpp opened this issue Apr 10, 2017 · 0 comments
Closed

Make browser container startup timeout configurable #326

pavelpp opened this issue Apr 10, 2017 · 0 comments

Comments

@pavelpp
Copy link
Contributor

pavelpp commented Apr 10, 2017 •
edited

Currently startup timeout is hardcoded at 120 seconds inside waitUntilContainerStarted() method, which is a total overkill. 5 seconds is a max I want to wait until container is started (typically it's around 3 seconds). Also using method withStartupTimeout() does nothing, as wait strategy is not used for browser container.
rnorth added a commit that referenced this issue Apr 15, 2017
@rnorth
Resolve #326, making browser container startup timeout configurable.
234215b 
Reduces default browser container startup timeout to 15s, down from an
unnecessarily high 120s.

This also replaces inheritance-based `waitUntilContainerStarted` with
composition-based `WaitStrategy`. The new `LogMessageWaitStrategy` allows
us to wait based upon the Selenium container log output, rather than the
 relatively expensive process of repeatedly trying to create and connect
 a `RemoteWebDriver` instance.
rnorth added a commit that referenced this issue Apr 17, 2017
@rnorth
Resolve #326, making browser container startup timeout configurable.
4ec0001 
Reduces default browser container startup timeout to 15s, down from an
unnecessarily high 120s.

This also replaces inheritance-based `waitUntilContainerStarted` with
composition-based `WaitStrategy`. The new `LogMessageWaitStrategy` allows
us to wait based upon the Selenium container log output, rather than the
 relatively expensive process of repeatedly trying to create and connect
 a `RemoteWebDriver` instance.
rnorth added a commit that referenced this issue Apr 30, 2017
@rnorth
Resolve #326, making browser container startup timeout configurable.
564583e 
Reduces default browser container startup timeout to 15s, down from an
unnecessarily high 120s.

This also replaces inheritance-based `waitUntilContainerStarted` with
composition-based `WaitStrategy`. The new `LogMessageWaitStrategy` allows
us to wait based upon the Selenium container log output, rather than the
 relatively expensive process of repeatedly trying to create and connect
 a `RemoteWebDriver` instance.
rnorth added a commit that referenced this issue Apr 30, 2017
@rnorth
Resolve #326, making browser container startup timeout configurable.
47f1959 
Reduces default browser container startup timeout to 15s, down from an
unnecessarily high 120s.

This also replaces inheritance-based `waitUntilContainerStarted` with
composition-based `WaitStrategy`. The new `LogMessageWaitStrategy` allows
us to wait based upon the Selenium container log output, rather than the
 relatively expensive process of repeatedly trying to create and connect
 a `RemoteWebDriver` instance.
@rnorth rnorth closed this as completed in c03fba3 May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavelpp