Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support docker compose versions >2.0 #422

Closed
grexe opened this issue Aug 1, 2017 · 4 comments
Closed

support docker compose versions >2.0 #422

grexe opened this issue Aug 1, 2017 · 4 comments

Comments

@grexe
Copy link
Contributor

grexe commented Aug 1, 2017

seems versions > 2.0 are not supported.
E.g. having a correct version 2.1, 2.2 or even the latest 3.x results in an error message:

[docker/compose:1.8.0] - STDERR: Version in `<compose.yaml>` is unsupported.

This is because the docker/compose container used is over a year old, latest is 1.15, see:
https://store.docker.com/community/images/docker/compose/tags

Please update the docker container used for compose containers so recent YAML files are supported.
Sadly this cannot be overridden like for other containers mentioned in custom containers

@grexe
Copy link
Contributor Author

grexe commented Aug 1, 2017

the 1.8.0 version is hard coded into ContainerisedDockerCompose, would be easy to make it parametrized via custom containers properties if there are no assumptions/dependencies in the code regarding the compose version:

    public ContainerisedDockerCompose(List<File> composeFiles, String identifier) {
        super("docker/compose:1.8.0");

I'm working on a PR to fix this, ok?

@bsideup
Copy link
Member

bsideup commented Aug 1, 2017

Hey @grexe,
PR sounds great, looking forward to it! 👍

@grexe
Copy link
Contributor Author

grexe commented Aug 1, 2017

looks quite good here, just testing with my app (the original goal,-)
Love Project Lombok btw, but the missing IntelliJ plugin bit me...

grexe pushed a commit to grexe/testcontainers-java that referenced this issue Aug 1, 2017
@grexe
Copy link
Contributor Author

grexe commented Aug 1, 2017

fixed in #425

@bsideup bsideup closed this as completed in 32b6551 Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants