Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Better WaitStrategy to ensure the Pulsar cluster is fully initialised #5513

Closed
nahguam opened this issue Jun 22, 2022 · 2 comments · Fixed by #5514
Closed

[Enhancement]: Better WaitStrategy to ensure the Pulsar cluster is fully initialised #5513

nahguam opened this issue Jun 22, 2022 · 2 comments · Fixed by #5514
Labels
type/enhancement

Comments

@nahguam
Copy link
Contributor

nahguam commented Jun 22, 2022 •
edited
Loading

Module

Pulsar

Proposal

The current PulsarContainer's WaitStrategy includes waiting for the metrics endpoint to be available. The metrics endpoint is activated before the cluster and default tenants and namespaces are created. On slower systems (perhaps Apple M1 silicon running under Rosetta 2 for x86 arch), if your first step after the container is ready is to start interrogating the admin API, then certain calls may get unexpected responses.

I propose to instead check the admin clusters endpoint to ensure that the standalone cluster has actually been created.
nahguam pushed a commit to nahguam/testcontainers-java that referenced this issue Jun 22, 2022
Check admin endpoint instead of metrics for Pulsar WaitStrategy. Fixes …
220e717 
…testcontainers#5513
@nahguam nahguam mentioned this issue Jun 22, 2022
Merged
@eddumelendez
Copy link
Member

Hi @nahguam thanks for opening the enhancement proposal but no need it if it comes with a PR just right after :)

@nahguam
Copy link
Contributor Author

nahguam commented Jun 22, 2022

@eddumelendez Ok Thanks for the guidance :)

nahguam pushed a commit to nahguam/testcontainers-java that referenced this issue Jun 23, 2022
@nahguam
Check admin endpoint instead of metrics for Pulsar WaitStrategy. Fixes …
a204ea2 
…testcontainers#5513
eddumelendez added a commit that referenced this issue Jun 28, 2022
@nahguam @eddumelendez @kiview
Check admin endpoint instead of metrics for Pulsar WaitStrategy. (#5514)
56d0cf1 
Fixes #5513

Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check admin endpoint instead of metrics for Pulsar WaitStrategy. nahguam/testcontainers-java
2 participants
@eddumelendez @nahguam