Should use Oracle Maven repository to obtain Oracle JDBC driver

[rnorth]

Now that the Oracle JDBC driver is available in a public repository, the oracle-xe module can be part of the CI build and there is no need for the proprietary-deps profile.

[kaiwinter]

Yes that would be great, but the oracle repository requires you to authorize yourself with your oracle account. It's not possible to have a private maven config where you can securely store this credentials on Circle CI I think. Do you have an idea on how to solve this?

Reference: Get Oracle JDBC drivers and UCP from Oracle Maven Repository

[rnorth]

Ah crap, I'd seen the other announcement but not groked the detail about needing to still use credentials. CircleCI's environment variables can technically be used to get credentials into the build, but to be secure you have to disable builds of PRs (in case they modify the build to steal the credentials). This isn't something I'd want to do.

Oh well, maybe something to come back to one day, but seems pretty improbable :(

[gdubya]

The time has come.... :) https://medium.com/@kuassimensah/oracle-jdbc-drivers-on-maven-central-64fcf724d8b

[rnorth]

Thanks for re-opening 😀

Contributions would be welcomed!

[kaiwinter]

This is undoubtedly great news. BUT I'm afraid I have to crash this party again somehow: It turned out that Oracle doesn't tolerate public Oracle docker images and sends DMCA Takedown Notices.

I was using wnameless/docker-oracle-xe-11g which was removed from Docker Hub because of this in the past. This issue sums it up: jhipster/generator-jhipster#9370.

I'm going to contribute a small change to the oracle-xe module to use an official JDBC driver but OracleJDBCDriverTest.testOracleWithNoSpecifiedVersion which is currenty annotated to be ignored cannot be un-ignored as there is no safe docker image.

[bsideup]

fixed in #1899