Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Switch from Google SDK to Google CLI and update Google Client Libraries BOM #7340

Closed
ddobrin opened this issue Jul 31, 2023 · 2 comments · Fixed by #7389
Closed

Comments

@ddobrin
Copy link
Contributor

ddobrin commented Jul 31, 2023

Module

GCloud

Proposal

The dependencies must be updated to use the Google Cloud CLI, as well as library updates

@eddumelendez
Copy link
Member

Hi @ddobrin, you mean switching from gcr.io/google.com/cloudsdktool/cloud-sdk to gcr.io/google.com/cloudsdktool/google-cloud-cli in our tests, right? BigtableEmulatorContainer, DatastoreEmulatorContainer, FirestoreEmulatorContainer and PubSubEmulatorContainer already support both images.

Dependabot will run tomorrow, so, I'll wait for it to update images and dependencies.

@ddobrin
Copy link
Contributor Author

ddobrin commented Jul 31, 2023

Hi @eddumelendez
yes, that's the one.

I would suggest also updating the Google client libraries BOM:
testImplementation platform("com.google.cloud:libraries-bom:26.19.0")

and the Guava version
testImplementation 'com.google.guava:guava:32.1.1-jre'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants