-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: MinioContainer wait strategy (log) doesn't work everytime #7892
Labels
Comments
Hi, thanks for the report. Can I ask you to try overriding
The key is switching to |
eddumelendez
added a commit
that referenced
this issue
Dec 1, 2023
Currently, log strategy is defined. Switching to HTTP strategy to `/minio/health/live` endpoint for reliability. Fixes #7892
eddumelendez
added a commit
that referenced
this issue
Dec 1, 2023
Currently, log strategy is defined. Switching to HTTP strategy to `/minio/health/live` endpoint for reliability. Fixes #7892
eddumelendez
added a commit
that referenced
this issue
Dec 1, 2023
Currently, log strategy is defined. Switching to HTTP strategy to `/minio/health/live` endpoint for reliability. Fixes #7892
Sorry for the late answer, but I tried it and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Module
MinIO
Testcontainers version
1.19.3
Using the latest Testcontainers version?
Yes
Host OS
MacOS
Host Arch
M1
Docker version
What happened?
I'm using the Minio Test container (image: minio/minio:RELEASE.2023-10-25T06-33-25Z) and the log strategy implemented by the MinIOContainer class doesn't work all the time.
The test container is declared in the tests as the following (S3Testcontainer is just a wrapper that extends MinIOContainer)
In the tests
@BeforeEach
I create a bucket for the tests and some times the creation fails withIf I add a wait after the container is "started" until the "listBuckets" is successful (sometimes more than one request is needed until the container responds) all the tests are green.
It seems that the "wait for" strategy using the logging is not the best approach and can lead to flaky tests.
Below I attached the logs of the container after it's started and while the
list buckets
request is successful. As one can see, the container waited until the log is written but then the requests still fail for a while.Relevant log output
Additional Information
No response
The text was updated successfully, but these errors were encountered: