Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SLF4J Profiler #1002

Merged
merged 4 commits into from
Dec 8, 2018
Merged

Remove SLF4J Profiler #1002

merged 4 commits into from
Dec 8, 2018

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Dec 2, 2018

This was useful while we were working to optimise performance, but now I feel it's just clutter and can be safely removed.

Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is great, thanks 😄

@bsideup
Copy link
Member

bsideup commented Dec 5, 2018

@rnorth we should remove it from build.gradle as well :)

@rnorth
Copy link
Member Author

rnorth commented Dec 5, 2018

Ahah. It’s been so long since I added it that I may have forgotten there was an extra dependency!

Sent with GitHawk

@rnorth rnorth merged commit dce6264 into master Dec 8, 2018
@delete-merged-branch delete-merged-branch bot deleted the remove-profiler branch December 8, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants