-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mockserver to 5.5.1 and bind to port 1080 which is default #1109
Conversation
e48f135
to
d0b3c20
Compare
in 5.5.1 they don't run container as root, so binding to 80 port doesn't work anymore mock-server/mockserver@6d33bd7#diff-ebacf6f6ae4ee68078bb16454b23247d
d0b3c20
to
a5a6f0e
Compare
modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java
Outdated
Show resolved
Hide resolved
modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marked as spam
modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, but perhaps we should go with try-with-resources inside the test methods? It's barely any different in terms of length of code. However, people might want to refer to these tests as a kind of example, so it's probably best to be Lombok-agnostic... |
Thanks for the quick turnaround @lanwen. Let's merge! |
in 5.5.1 they don't run container as root, so binding to 80 port
doesn't work anymore
mock-server/mockserver@6d33bd7#diff-ebacf6f6ae4ee68078bb16454b23247d