Add additional convenience methods for Neo4j containers #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
requested review from
bsideup,
kiview and
rnorth
as code owners
bsideup
reviewed
Feb 15, 2019
bsideup
reviewed
Feb 15, 2019
modules/neo4j/src/test/java/org/testcontainers/containers/Neo4jContainerTest.java
Outdated
Show resolved
Hide resolved
michael-simons
force-pushed
the
feature/new-neo4j-functions
branch
from
7e5e875
to
d5e5c80
Compare
|
@michael-simons great job, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following methods for the Neo4j container
•
public S withDatabase(MountableFile graphDb)•
public S withPlugins(MountableFile plugins)•
public S withNeo4jConfig(String key, String value)•
public S withoutAuthentication()Those have been described in the readme of Neo4j.
For being able to test
withDatabase, I have added a very small Neo4jgraph.dbstore to the test-resources. This is our native format.For testing
withPluginsI wanted to avoid adding a binary jar, so I added a submodule being build before the test. My Gradle foo is not that good, maybe there's a better way to do this.Thanks for taking the PR into consideration. The Neo4j container has been a great success with some of our partners and customers so far.