-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example for MongoDB containers #1288
Conversation
Travis fails of because of Gradle build scan, not really related to this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks.
Just some minor remarks.
If you like, you can also include this example into the actual docs in a later PR (not mandatory of course).
examples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
examples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
...ples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainerTest.java
Outdated
Show resolved
Hide resolved
@slu-it is this PR still under development? Is it ready for review? |
@sullis the PR is ready for review - I might have worded my last comment a little bit vague. I meant to say that I would take a look at the documentation suggestion in another PR at a later time |
* {@link #setPortBindings(java.util.List)}. | ||
*/ | ||
public static final int MONGODB_PORT = 27017; | ||
public static final String DEFAULT_IMAGE_AND_TAG = "mongo:4.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MongoDB's versioning scheme is described here:
https://docs.mongodb.com/manual/release-notes/#release-version-numbers
Release series ending with even numbers (e.g. 4 above) are stable and ready for production, while odd numbers are for development and testing only.
IMO -- the default image should be "mongo:4.0" (a stable, production ready version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT? @slu-it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sullis i changed it to version 4.0
- did not know about MongoDB's "interesting" version schema.
LGTM. can we merge this? |
Yes |
can we merge this today? |
LGTM @slu-it |
Merged, thanks @slu-it for sticking with this for a longer time 🙂 |
thank you for merging :) |
Released in 1.11.3. Thanks for the contribution! |
New PR since the old PR branch (#803) got deleted by accident ... This time as an example.