-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for the StartupCheckStrategy timeout value to be configurable. #1308
Conversation
I think I am having a similar problem, could you share the stacktrace you are getting? |
can we make sure that this timeout can also be configured when using |
you should get something like:
DockerComposeContainer seems to be working a bit differently than the GenericContainer. |
I think this looks like a good improvement to me, thank you @mimfgg. However, I'm a little confused:
I'd be happy to accept this change, but if this stack trace is your only problem I'd worry that this PR might not help you! Please can you confirm? |
yes, I picked the wrong log... however I don't really understand something, the actual trace we have is:
which doesn't match the source I get for version 1.10.5 we have as a dependency: ... And I now see the -retag version. I think that some of our servers have the original 1.10.5 cached not the retag. I'll bump to 1.10.7 and do more debugging. |
I don't really manage to reproduce this behaviour in 1.10.7. You can merge this PR or just close it if this property doesn't really need to be set ... our artifactory just has a 1.10.5 (not retagged) version cached, I think we'll just move on :) |
Released in 1.11.2! |
in case of big docker images (Elasticsearch 6.6.0 is 808MB for example) the hardcoded 30s timeout makes a lot of our builds fail the first time they run.
We fixed this locally, but it would be nice to have it as a parameter on the parent class.