-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hostPort != containerPort #1334
hostPort != containerPort #1334
Conversation
core/src/main/java/org/testcontainers/containers/PortForwardingContainer.java
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/PortForwardingContainer.java
Outdated
Show resolved
Hide resolved
@bopi- one last thing - could you please implement a test for it? |
core/src/test/java/org/testcontainers/containers/ExposedHostTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/testcontainers/containers/ExposedHostTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/testcontainers/containers/ExposedHostTest.java
Outdated
Show resolved
Hide resolved
@bopi- I just applied some minor changes myself and ready to merge as soon as the CI status is green 👍 |
yeah. naming and caching ... 😃 |
@bopi- merged! Thanks a lot for your contribution 👍 |
@bsideup thank you! Especially for your super fast responses! Do you have an Idea when this can be released? |
@bopi- it will be released soon since we have a couple of urgent things to be released, probably this weekend |
Released in 1.11.2! |
This makes it possible that e.g. the actual hostport is a random one but in the container its always 80