-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure pipelines #1363
Azure pipelines #1363
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
/AzurePipelines run Windows 10 - Docker for Windows |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
inputs: | ||
gradleWrapperFile: 'gradlew' | ||
jdkVersionOption: '1.8' | ||
options: '--no-daemon --continue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we actually use the daemon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't, given that it is running on an actual machine that being reused and may cause troubles
boolean result = new QueryRunner(dataSource, options.contains(Options.PmdKnownBroken)).query("SELECT 1", rs -> { | ||
rs.next(); | ||
int resultSetInt = rs.getInt(1); | ||
assertEquals("A basic SELECT query succeeds", 1, resultSetInt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably missing something (and it's just copied from the original code), but why don't we return resultSetInt == 1
instead of the assertEquals
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just an indentation change. Let's discuss/change it separately :)
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.