Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shading of modules #1390

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix shading of modules #1390

merged 1 commit into from
Apr 11, 2019

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Apr 11, 2019 •
edited

Fixes #1342

@bsideup bsideup added this to the next milestone Apr 11, 2019
@bsideup bsideup requested a review from a team April 11, 2019 10:17
rnorth
rnorth approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty involved, but fine to me!

After merge, I'll try and spend a bit of time going through #1342, as I'd like to see the effects for myself!

@bsideup bsideup merged commit 3b9e61e into master Apr 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_shading branch April 11, 2019 15:51
@bsideup bsideup mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
area/shading blocker type/bug type/housekeeping
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @rnorth