Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1389 Override close method of Network without throws statement #1392

Merged
merged 2 commits into from
Apr 15, 2019
Merged

#1389 Override close method of Network without throws statement #1392

merged 2 commits into from
Apr 15, 2019

Conversation

mumukiller
Copy link
Contributor

@mumukiller mumukiller commented Apr 11, 2019 •
edited

If my understanding of the issue is correct this will be the suggested fix :)

@mumukiller mumukiller changed the title #1389 Override close method without throws statement #1389 Override close method of Network without throws statement Apr 11, 2019
rnorth
rnorth approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mumukiller, LGTM!

Fixes #1389

@rnorth rnorth merged commit 978d374 into testcontainers:master Apr 15, 2019
@rnorth rnorth added this to the next milestone Apr 15, 2019
@rnorth
Copy link
Member

rnorth commented Apr 16, 2019

Released in 1.11.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mumukiller @rnorth