Break up quickstart example projects and introduce JUnit 5 refe… #1416
Conversation
I think it would be more straight forward to keep the structure you have right now. How about merging this PR first? I'd be happy to follow up with another PR shortly thereafter that moves the examples in general. This approach would lead to less, better reviewable changes per PR as all references to example would have to be changed. |
|
@kiview Any more thoughts on this? Is there anything else I can do to get the changes merged? |
|
Is this still of interest? Otherwise I might as well close it. |
|
Sorry @bmuschko this is still of interest - we've just all been quite snowed under for several weeks. I'll try and review/merge this week. I'm very sorry for the delay. |
There was a problem hiding this comment.
I think this is fine apart from a couple of very minor points.
Directory structure-wise we have to acknowledge that this isn't the final state. It's OK to get the content in and then refactor.
I think I'll want to do another bulk move of content once this and #1499 are merged.
| compile "io.lettuce:lettuce-core:5.1.1.RELEASE" | ||
|
|
||
| def junitJupiterVersion = '5.4.2' | ||
| testCompile "org.junit.jupiter:junit-jupiter-api:$junitJupiterVersion" |
There was a problem hiding this comment.
Please could you inline the versions and remove the variable? Even though it causes duplication, Dependabot can then keep the versions up to date.
Dependabot needs to be able to discover those and propose a change.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
@bsideup please could you resolve the merge conflicts, then I think it's basically good to go. It would be good to have another go at making the docs codeinclude the dependencies directly from the relevant We could do that later though; it'd be good to get this merged even without that. |
bsideup
force-pushed
the
junit5-quickstart
branch
from
92cbc2f
to
2c3b36a
Compare
|
@rnorth resolved |
rnorth
changed the title
* Break up quickstart example projects and introduce JUnit 5 refe… (#1416) * Break up quickstart example projects and introduce JUnit 5 reference * Use for dependency declarations Dependabot needs to be able to discover those and propose a change. * Relocate Spock example code Co-authored-by: Benjamin Muschko <benjamin.muschko@gmail.com>
This change adds a quickstart reference for using TestContainers with JUnit 5. Still uses the "old" Gradle configurations to ensure uniformity across the whole documentation.
inside_block#1415