Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped up default version of Confluent Platform to the current 5.2.1 (Kafka container) #1446

Merged
merged 6 commits into from
Jul 16, 2019
Merged

Bumped up default version of Confluent Platform to the current 5.2.1 (Kafka container) #1446

merged 6 commits into from
Jul 16, 2019

Conversation

wlsc
Copy link
Contributor

@wlsc wlsc commented May 2, 2019

  • Bumped up default version of Confluent Platform to the current 5.2.1 (Kafka container)

@rnorth
Copy link
Member

rnorth commented May 7, 2019

As it's a major version bump, are there any changes that could be considered breaking for our users?

@wlsc
Copy link
Contributor Author

wlsc commented May 7, 2019

@rnorth according to the existing KafkaContainerTest.java, there should be no changes that would directly affect existing users. Test has been executed and green.

@bsideup bsideup added this to the next milestone Jul 16, 2019
@bsideup
Copy link
Member

bsideup commented Jul 16, 2019

I reverted the ZK change to verify that the change is backward compatible with external ZK

@bsideup bsideup merged commit 1d6ab93 into testcontainers:master Jul 16, 2019
@bsideup
Copy link
Member

bsideup commented Jul 16, 2019

@wlsc merged, thanks! 👍

@bsideup bsideup added the dependencies Pull requests that update a dependency file label Jul 21, 2019
@wlsc wlsc deleted the update/kafka-container-to-current-version branch August 4, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wlsc @rnorth @bsideup