-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitMQ module #1449
Add RabbitMQ module #1449
Conversation
Added RabbitMQ SSL option
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
…abbitMQContainer.java Co-Authored-By: martingreber <31406507+martingreber@users.noreply.github.com>
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Show resolved
Hide resolved
...es/rabbitmq/src/main/java/org/testcontainers/containers/ContainerConfigurationException.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/test/java/org/testcontainers/containers/RabbitMQContainerTest.java
Outdated
Show resolved
Hide resolved
…abbitMQContainer.java Co-Authored-By: martingreber <31406507+martingreber@users.noreply.github.com>
Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.12.0 to 3.12.1. <details> <summary>Commits</summary> - [`8cc755f`](assertj/assertj@8cc755f) [maven-release-plugin] prepare release assertj-core-3.12.1 - [`14384ec`](assertj/assertj@14384ec) Avoid generating a module-info class. Fixes [#1448](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1448) - [`fb75625`](assertj/assertj@fb75625) anySatisfy: do not continue evaluating elements once we found a match - [`c8a6798`](assertj/assertj@c8a6798) fix a minor typo ([#1449](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1449)) - [`4e32776`](assertj/assertj@4e32776) Fail with error message if the given expectedStringTemplate is null ([#1450](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1450)) - [`2cba38f`](assertj/assertj@2cba38f) fix some more javadoc errors ([#1447](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1447)) - [`50e2e3a`](assertj/assertj@50e2e3a) Use String#join where possible - [`fa94bf2`](assertj/assertj@fa94bf2) Javadoc fixes ([#1444](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1444)) - [`e3c2a57`](assertj/assertj@e3c2a57) Update Memory File System to 2.1.0 - [`2c57b2b`](assertj/assertj@2c57b2b) Fix javadoc and reenable Javadoc doclint verification ([#1438](https://github-redirect.dependabot.com/joel-costigliola/assertj-core/issues/1438)) - Additional commits viewable in [compare view](assertj/assertj@assertj-core-3.12.0...assertj-core-3.12.1) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=org.assertj:assertj-core&package-manager=gradle&previous-version=3.12.0&new-version=3.12.1)](https://dependabot.com/compatibility-score.html?dependency-name=org.assertj:assertj-core&package-manager=gradle&previous-version=3.12.0&new-version=3.12.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Hey guys, could you review the changes? All review comments have been addressed. Cheers! |
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice PR - thanks for the contribution. I've added a few very small comments, but nothing big!
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
modules/rabbitmq/src/main/java/org/testcontainers/containers/RabbitMQContainer.java
Outdated
Show resolved
Hide resolved
…eo4JContainer author, Michael J. Simons :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bon soir mes amis je vous demande à quoi sert ces applications et comment les installer aux bureau
Hi guys, all resolved. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rnorth, sorry these changes have already been applied on the branch, plus some bug fixes, so I think it's better to just look at commits on the branch itself.
Hey guys, any plans on merging this PR? |
Sorry @martingreber, we've all been tied up over the last few weeks. I'll aim to have a final re-review and merge tomorrow. Sorry for the delay. |
FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 will merge once CI is green 🎉
CI is green (I did not count the unrelated failures to the CI problems we currently have) |
@martingreber thanks for your contribution! Sorry that it took so long! |
Added RabbitMQContainer module so you can create a RabbitMQ container like this:
Or with a more complex example:
#1447