-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tmpfs to ContainerDatabaseDriver #1500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - thank you!
Just one suggestion: I think this deserves a docs update. Please could you add a subsection to docs/modules/databases/index.md
, similar to how other URL params are described?
Hi Richard, thank you for your review. Yes, you are right. We should add some explanation to the documentation. I will do it in the next day. Best regards, Sandra |
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Co-Authored-By: Kevin Wittek <kiview@users.noreply.github.com>
Great work everyone, thanks! |
This was released in 1.11.4 🎉 Thank you for the contribution! |
fix #1239
Created during Hackergarten at Gr8Conf with @georgberky and @kiview