Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tmpfs to ContainerDatabaseDriver #1500

Merged
merged 8 commits into from
Jun 4, 2019
Merged

Add support for tmpfs to ContainerDatabaseDriver #1500

merged 8 commits into from
Jun 4, 2019

Conversation

sparsick
Copy link
Contributor

fix #1239

Created during Hackergarten at Gr8Conf with @georgberky and @kiview

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - thank you!
Just one suggestion: I think this deserves a docs update. Please could you add a subsection to docs/modules/databases/index.md, similar to how other URL params are described?

@sparsick
Copy link
Contributor Author

Hi Richard,

thank you for your review. Yes, you are right. We should add some explanation to the documentation. I will do it in the next day.

Best regards,

Sandra

sparsick and others added 6 commits May 29, 2019 10:23
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
Co-authored-by: georgberky <georgberky@users.noreply.github.com>
@kiview kiview added this to the next milestone Jun 3, 2019
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

docs/modules/databases/index.md Outdated Show resolved Hide resolved
sparsick and others added 2 commits June 3, 2019 18:21
Co-Authored-By: Kevin Wittek <kiview@users.noreply.github.com>
@kiview kiview merged commit a44f357 into testcontainers:master Jun 4, 2019
@kiview
Copy link
Member

kiview commented Jun 4, 2019

Great work everyone, thanks!

@rnorth
Copy link
Member

rnorth commented Jul 7, 2019

This was released in 1.11.4 🎉

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring tmpfs for database container launched via JDBC URL scheme
4 participants