Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 5.6.2 #1510

Merged
merged 12 commits into from
Oct 4, 2019
Merged

Update Gradle to 5.6.2 #1510

merged 12 commits into from
Oct 4, 2019

Conversation

kiview
Copy link
Member

@kiview kiview commented May 29, 2019

This adds automatic retry for plugin resolving.

Fixes #898

@rnorth
Copy link
Member

rnorth commented Jun 6, 2019

Hmm, build failing... This looks like a similar issue: projectlombok/lombok#1945

@bsideup bsideup mentioned this pull request Jun 6, 2019
@guenhter
Copy link
Contributor

guenhter commented Jun 6, 2019

Maybe you execute this once in the repo:

./gradlew wrapper --gradle-version=5.4.1 --distribution-type=all

Then also the wrapper itself is upgraded (and in this case some license information is adapted).

@guenhter
Copy link
Contributor

guenhter commented Jul 9, 2019

5.5. was released a couple of days ago. Maybe that one should be switched to already:

./gradlew wrapper --gradle-version=5.5 --distribution-type=all

@kiview
Copy link
Member Author

kiview commented Jul 11, 2019

@guenhter Thanks for the pointer, I will update it accordingly.
Problem was not the version, but that there were some incompatibilities in the build regarding Lombok.

I need to pickup this PR again soon...

@bsideup
Copy link
Member

bsideup commented Jul 16, 2019

@kiview examples seem to fail after the upgrade

@kiview
Copy link
Member Author

kiview commented Jul 16, 2019

Let me try to come back to this later this week 🙂

@kiview kiview changed the title Update Gradle to 5.4.1 Update Gradle to 5.6.2 Sep 24, 2019
@kiview
Copy link
Member Author

kiview commented Sep 25, 2019

@rnorth @bsideup
Finally all quirks are solved 😅, ready for review

@rnorth rnorth added this to the next milestone Sep 28, 2019
@rnorth
Copy link
Member

rnorth commented Oct 1, 2019

As @kiview is on holiday I'll quickly pick this up and apply a tiny change to satisfy my comment 😁

@rnorth rnorth merged commit a9aa07c into master Oct 4, 2019
@rnorth rnorth deleted the gradle5 branch October 4, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plugin resolution fails intermittently during CI builds
4 participants