Amend container shutdown to catch and log for all Exception classes #1663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #1420 to fix incomplete error handling
Refs #1379
We found that unfortunately #1420 had some issues:
ConflictException
messages didn't actually correctly detect the error message in the exception.We decided to simplify and just catch
Exception
, since we don't actually care about what might have caused container deletion to fail.It is causing exceptions like these, failing tests: