Automatically set SHM for selenium container, and allow SHM size to be configured #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Aug 25, 2019
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
bsideup
previously requested changes
Sep 18, 2019
bsideup
reviewed
Sep 24, 2019
modules/selenium/src/test/java/org/testcontainers/junit/BrowserWebDriverContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Sep 24, 2019
| ) { | ||
| webDriverContainer.start(); | ||
| assertEquals("Shared memory size is configured", 512 * FileUtils.ONE_MB, webDriverContainer.getShmSize()); | ||
| assertEquals("No mounts present", webDriverContainer.getContainerInfo().getMounts().size(), 0); |
There was a problem hiding this comment.
please check that there are no shm mounts, not just any, so that if we add some volumes in future, it won't break the test (same in createContainerWithShmVolume)
There was a problem hiding this comment.
FTR this one was only partially resolved. @glefloch please do not resolve other's comments, let the author resolve it when he thinks it is so
There was a problem hiding this comment.
Sorry @bsideup, I will open another pull request with this fix. I thought it was only for this test...
bsideup
reviewed
Sep 24, 2019
modules/selenium/src/test/java/org/testcontainers/junit/BrowserWebDriverContainerTest.java
Outdated
Show resolved
Hide resolved
|
@rnorth I left a couple of comments about the tests, good to go once fixed :) |
rnorth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1670 by setting the shared memory to 2Go.