-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check for compatible Docker OS type #1780
add check for compatible Docker OS type #1780
Conversation
as Windows containers are not supported at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things here:
- please check for "linux" instead of "not windows", just in case
- I would make it more generic, for every strategy. e.g. check for
OSType
after calling.test()
inDockerClientProviderStrategy
@bsideup checking for |
@Casz we would have to adapt if they introduce macOS or ARM containers too, so I would rather stick to what we explicitly support |
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Outdated
Show resolved
Hide resolved
This will unblock something like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me, thank you @Casz.
Thank you 🙌 |
as Windows containers are not supported at the moment
resolves #1765
works out great 🙌