Speed up open port detection by running the checks as a single command #1782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1781 (and it is all about the ultra fast tests) I noticed that the port checks take quite some time.
This change will:
docker exec
command rather thanNUM_PORTS * NUM_STRATEGIES
commands (3, 6, 9...)Measurements
Even for 1 port, it is:
Before (1,443ms):
After (1,060ms):