-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate "environment" and "classpath" properties (for global things) #1784
Separate "environment" and "classpath" properties (for global things) #1784
Conversation
@@ -71,13 +82,18 @@ public String getPulsarImage() { | |||
} | |||
|
|||
public boolean isDisableChecks() { | |||
return Boolean.parseBoolean((String) properties.getOrDefault("checks.disable", "false")); | |||
return Boolean.parseBoolean((String) environmentProperties.getOrDefault("checks.disable", "false")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was never supposed to be disabled in classpath' file, but some users were misusing it and setting it "for everyone".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible 👍
} | ||
|
||
public String getDockerClientStrategyClassName() { | ||
return (String) properties.get("docker.client.strategy"); | ||
return (String) environmentProperties.get("docker.client.strategy"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not make sense to have it "for everyone" as well since it is strictly environment specific
Also removed the "transportType" check because Netty is no longer supported