Remove hostname and port from JDBC examples to avoid confus…
#1786
Conversation
|
|
||
| Insert `tc:` after `jdbc:` as follows. Note that the hostname, port and database name will be ignored; you can leave these as-is or set them to any value. | ||
|
|
||
| ### JDBC URL examples | ||
|
|
||
| #### Using Testcontainers with a fixed version | ||
|
|
||
| `jdbc:tc:mysql:5.6.23://somehostname:someport/databasename` | ||
| `jdbc:tc:mysql:5.6.23:///databasename` |
There was a problem hiding this comment.
I suspect that many people will be so used to seeing hostname:port parts in JDBC URLs that it'll be quite surprising to see them omitted - i.e. it will look unfamiliar to the point of being weird.
Could we perhaps have a 'note' callout under line 52 explaining and showing that scheme://foo:bar/baz and scheme:///baz are equivalent?
There was a problem hiding this comment.
The problem I seen was people putting localhost:3306 there and expecting the DB to actually run on these host/port (by attaching MySQL Workbench or something else).
This magical /// can be a good indicator that the host/port are unknown and will be magically set later. WDYT?
There was a problem hiding this comment.
Sure, I'm totally in favour of this PR, but I think we need to explain or reword line 52 at a minimum.
I'd be willing to bet that many people haven't made the connection in their heads that host-less URIs are a thing (despite the existence of file URIs!).
rnorth
changed the title
hostname and port from JDBC examples to avoid confusionhostname and port from JDBC examples to avoid confus…
Since they are ignored, it is better to not have any defaults to avoid confusing the users.
///databasename-style URLs work great and raise less questions IMO :)