Correct shading for netty native linux lib; add guava shading and fix bouncycastle certs #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n shading dependencies.
…ion to prevent `java.lang.SecurityException: Invalid signature file digest for Manifest main attributes`
|
Looks good to me, one test is however failing on the CI server which I cannot relate to this change. |
|
@raphw thanks. I've re-run the CI job - I suspect this is a case of a timeout being too short. |
|
@rnorth Looks good now. Great if you can release this some time soon. I am currently running against a custom build. Thanks for the quick reaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up from #180 where the majority of the work was done to address #178 and #179.
If this looks good to people (please test in other environments!) this will become 1.1.2.
I've tested locally on Mac (docker-machine) and Ubuntu (local docker).