Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionWrapper#rollback(Savepoint) delegates to wrong method #1909 #1937

Merged
merged 3 commits into from
Oct 3, 2019
Merged

ConnectionWrapper#rollback(Savepoint) delegates to wrong method #1909 #1937

merged 3 commits into from
Oct 3, 2019

Conversation

MariuszCwikla
Copy link
Contributor

Fixes #1909

@bsideup
Copy link
Member

bsideup commented Oct 2, 2019

Hi @MariuszCwikla,

As discussed in the issue ( #1909 (comment) ), @thiyagu-7 wanted to submit a fix for this one, since it was up for grabs.

I suggest we wait one day and if he did not, we will merge yours as it seems to be the exact fix for the issue and follows the guideline.

We do this to respect first responders, but appreciate your time you spend submitting the PR!
Or maybe @thiyagu-7 will agree to merge yours instead :)

@thiyagu-7
Copy link

@bsideup I'm happy to let you merge @MariuszCwikla's changes.

@bsideup
Copy link
Member

bsideup commented Oct 2, 2019

thanks @thiyagu-7!

@MariuszCwikla
Copy link
Contributor Author

I suggest we wait one day and if he did not, we will merge yours as it seems to be the exact fix for the issue and follows the guideline.

My bad; ok, agreed.

@bsideup
Copy link
Member

bsideup commented Oct 2, 2019

@MariuszCwikla all good, @thiyagu-7 have agreed to merge yours instead 👍

@bsideup bsideup added this to the next milestone Oct 2, 2019
@bsideup
Copy link
Member

bsideup commented Oct 2, 2019

@MariuszCwikla I applied a small fix and will merge once CI is green 🎉 👍

@bsideup bsideup merged commit ca8a35d into testcontainers:master Oct 3, 2019
@bsideup
Copy link
Member

bsideup commented Oct 3, 2019

@MariuszCwikla merged, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
modules/jdbc resolution/acknowledged
Projects
None yet
Milestone
1.12.3
Development

Successfully merging this pull request may close these issues.

ConnectionWrapper#rollback(Savepoint) delegates to wrong method
3 participants
@MariuszCwikla @bsideup @thiyagu-7