-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MongoDB module #1961
Add MongoDB module #1961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I'm still only about half way through but have run out of time for now - I think there's a few things to discuss. My last comment is possibly the trickiest thing so far.
Thank you for this work so far - hoping we can get this done!
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
Hi @rnorth, |
Sorry, we prefer it if we get the chance to press the resolve button for comments, as it means we can keep track of what we've re-reviewed. I'm going to unresolve all, but please don't take this as meaning I'm not happy with the change, it's just that I've not re-reviewed yet. Sorry for the long time between the last review and now. |
Hi @rnorth , It's fair enough to unresolve all the discussions. |
Looking at this again, I'm afraid I feel that we should simplify the testing a lot. There is a lot of code here - which means a lot of code that we have to be willing to maintain. It seems to me that I'd be happy to make these changes myself if you prefer, as I'm keen that we actually get this PR integrated - sorry that it's been so long. |
The testing code here stands for the 90%+ code coverage of MongoDB module, and yet I understand your concern about maintainability.
Indeed, TransactionITTest mostly copies the code that MongoDB offical docs set as an example
Ok, please, do it. Also, let me know if you need my help. |
Thanks for being understanding @silaev 🙇♂️. I've made tweaks locally; would you mind if I push to your remote? This PR comes from your |
modules/mongodb/src/test/java/org/testcontainers/containers/MongoDbContainerTest.java
Outdated
Show resolved
Hide resolved
The docs' look weird: I guess "Java8 MongoDbContainer for constructing a single node MongoDB replica set." is not needed as it is obvious, and the multi-node note should become a note section Also, I just noticed |
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDbContainer.java
Outdated
Show resolved
Hide resolved
@bsideup I’ve addressed all the discussions, please, check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me 😄 🎉
Thank you @silaev for your contribution, epic patience and flexibility as we worked through the reviews. 🙇♂️
Thank you, my pleasure |
Java8 MongoDbContainer for constructing a single node MongoDB replica set.