Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic GitHub Action for release #1991

Merged
merged 7 commits into from
Nov 28, 2019
Merged

Basic GitHub Action for release #1991

merged 7 commits into from
Nov 28, 2019

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Oct 20, 2019

Refs #1835


on:
release:
types: [published]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 😍

@rnorth rnorth added this to the next milestone Oct 20, 2019
Co-Authored-By: Sergei Egorov <bsideup@gmail.com>
@bsideup
Copy link
Member

bsideup commented Oct 20, 2019

@rnorth since we added the ./gradlew check to the release, we may have a problem of timeouts (will test everything, including the modules)
Perhaps we should also migrate other test stages we had in Travis and depend on them in the release stage, so that we run core, modules and other stages in parallel?

@bsideup bsideup modified the milestones: 1.12.3, next Oct 26, 2019
(release runs without testing - should be manually verified that master branch is stable)
@rnorth
Copy link
Member Author

rnorth commented Oct 30, 2019

As discussed briefly on Slack, we'll make this release step verify that checks are succeeding for the branch to be published.

I'll code up a GitHub Action to do that separately.

For this PR, I've just removed the explicit check step: we can easily manually verify that master is green before doing a release, until there's an automated GitHub Action to act as a guard.

@bsideup
Copy link
Member

bsideup commented Oct 30, 2019

@rnorth I was wondering if a simple shell script is sufficient for it, since we don't need an authentication to access the commit's status, and can simply curl it and assert the result (this part may not be trivial, curious if GHA have jq installed)

@rnorth
Copy link
Member Author

rnorth commented Oct 30, 2019

Helpfully, jq is available, so will do that!

Co-Authored-By: Sergei Egorov <bsideup@gmail.com>
@@ -0,0 +1,22 @@
name: Gradle Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing - I just spotted that the file name (gradle-release.yml) and the stage's name are a bit too specific.

Although I don't mind being specific about the step itself (e.g. "Publish to Bintray"), I am not sure we need "Gradle" in the name :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, I don't really mind much either way, so can change!

@rnorth rnorth self-assigned this Nov 1, 2019
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind as it is, although making it less specific about the step would be a nice improvement :)

@rnorth rnorth merged commit 50ff2c5 into master Nov 28, 2019
@rnorth rnorth deleted the github-action-release branch November 28, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants