-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic GitHub Action for release #1991
Conversation
.github/workflows/gradle.yml
Outdated
|
||
on: | ||
release: | ||
types: [published] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 😍
Co-Authored-By: Sergei Egorov <bsideup@gmail.com>
@rnorth since we added the |
(release runs without testing - should be manually verified that master branch is stable)
As discussed briefly on Slack, we'll make this release step verify that checks are succeeding for the branch to be published. I'll code up a GitHub Action to do that separately. For this PR, I've just removed the explicit |
@rnorth I was wondering if a simple shell script is sufficient for it, since we don't need an authentication to access the commit's status, and can simply |
Helpfully, |
Co-Authored-By: Sergei Egorov <bsideup@gmail.com>
@@ -0,0 +1,22 @@ | |||
name: Gradle Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing - I just spotted that the file name (gradle-release.yml
) and the stage's name are a bit too specific.
Although I don't mind being specific about the step itself (e.g. "Publish to Bintray"), I am not sure we need "Gradle" in the name :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK, I don't really mind much either way, so can change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mind as it is, although making it less specific about the step would be a nice improvement :)
Refs #1835