Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future-proofing TestEnvironmentTest #2036

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Future-proofing TestEnvironmentTest #2036

merged 1 commit into from
Nov 6, 2019

Conversation

pivovarit
Copy link
Contributor

Future-proofing TestEnvironmentTest by making sure we rely on Comparable#compareTo contract and not on ComparableVersion's implementation details.

/**
 * Compares this object with the specified object for order.  Returns a
 * negative integer, zero, or a positive integer as this object is less
 * than, equal to, or greater than the specified object. (...)
 */
public int compareTo(T o);

@bsideup bsideup added this to the next milestone Nov 6, 2019
bsideup
bsideup approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@bsideup bsideup merged commit 9b1077b into testcontainers:master Nov 6, 2019
@bsideup bsideup mentioned this pull request Nov 8, 2019
Closed
@pivovarit pivovarit deleted the future-proof-test-environment-test branch November 8, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/test-improvement
Projects
None yet
Milestone
1.12.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pivovarit @bsideup