Make Startables#deepStart
always iterate sequentially
#2053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Startables#deepStart
doesn't sanitize the Stream parameter which makes the method exposed to a bug when receiving a parallelizedStream<Startable
instance.Ideally, I'd replace
Stream<Startable>
withSet<Startable>
but the public API needs to be respected - consider deprecation.The test is non-deterministic when it comes to exposing a bug.