Stabilize CouchbaseContainer by merging the Socat command #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
commented
Nov 17, 2019
| .exec(); | ||
|
|
||
| dockerClient.execStartCmd(createCmdResponse.getId()) | ||
| .exec(new ExecStartResultCallback()); | ||
| .exec(new ExecStartResultCallback()) | ||
| .awaitCompletion(10, TimeUnit.SECONDS); |
There was a problem hiding this comment.
FYI we were missing awaitStarted here, and I guess it caused some races
kiview
approved these changes
Nov 18, 2019
| .exec(); | ||
|
|
||
| dockerClient.execStartCmd(createCmdResponse.getId()) | ||
| .exec(new ExecStartResultCallback()); | ||
| .exec(new ExecStartResultCallback()) | ||
| .awaitCompletion(10, TimeUnit.SECONDS); |
|
Nice! Absence of this looks like a bug, so let's merge it. I'm running a soak test for this change and will report back this evening. Fingers crossed! 🤞 |
bsideup
added a commit
that referenced
this pull request
Nov 27, 2019
bsideup
added a commit
that referenced
this pull request
Nov 27, 2019
* Restore `@Flaky` in Couchbase tests (partially revert #2081) * Manually start/stop container, do not reuse environment/cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1453