Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptLicense method to MSSQLServerContainer #2085

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Nov 18, 2019

Fixes: #2050

Adds accept license method to the MSSQLServerContainer class while still allowing users to accept the license via a resource file. Updated customizable test class to use the new method, while the simple test class uses the resource file. Also updated documentation.

@KyleAure
Copy link
Contributor Author

For issue #2050

@KyleAure
Copy link
Contributor Author

Resolved merge conflicts

@rnorth rnorth self-assigned this May 9, 2020
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this has languished for a long time, @KyleAure. I think this is fine and doesn't require any changes. Thank you for the contribution 🙇‍♂️

@KyleAure
Copy link
Contributor Author

KyleAure commented Jun 5, 2020

@rnorth thank you so much! It looks like I don't have authorization to merge.
Is that something you will need to do?

@rnorth
Copy link
Member

rnorth commented Jun 5, 2020

@KyleAure yep - will do now 😄

@rnorth rnorth changed the title add acceptLicense method to SQLServer Add acceptLicense method to MSSQLServerContainer Jun 5, 2020
@rnorth rnorth merged commit ddae79c into testcontainers:master Jun 5, 2020
@KyleAure KyleAure deleted the 2050-sqlserver-eula branch June 8, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLServer ACCEPT_EULA method
3 participants