-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apache Solr Module #2123
Add Apache Solr Module #2123
Conversation
* SolrContainer provides the TestContainer. * SolrClientUtils can be used to create collections and upload configuration. * SolrContainerConfiguration is a container to store all configuration options for the container. Documentation was added in the docs/modules folder.
Hi @rnorth, @bsideup and @kiview, i think the world needs to have solr Testcontainers :D |
Add incubation notice in the Documentation for the solr module
Added a simple example how to use the solr container with a custom collection name
modules/solr/build.gradle
Outdated
|
||
dependencies { | ||
compile project(':testcontainers') | ||
compile 'org.apache.httpcomponents:httpclient:4.5.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI to avoid an additional dependency, you can also use OkHttp that comes as a transitive dependency from the core module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed with 681a5e9
Replace the httpclient dependency with okhttp. okhttp is already included in testcontainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking a long time to review. I've added some comments - mostly small things. Thanks for the contribution!
examples/solr-container/src/test/java/com/example/SolrQueryTest.java
Outdated
Show resolved
Hide resolved
modules/solr/src/main/java/org/testcontainers/containers/SolrClientUtils.java
Show resolved
Hide resolved
modules/solr/src/main/java/org/testcontainers/containers/SolrContainer.java
Outdated
Show resolved
Hide resolved
modules/solr/src/main/java/org/testcontainers/containers/SolrContainer.java
Outdated
Show resolved
Hide resolved
modules/solr/src/main/java/org/testcontainers/containers/SolrContainer.java
Outdated
Show resolved
Hide resolved
modules/solr/src/main/java/org/testcontainers/containers/SolrContainer.java
Outdated
Show resolved
Hide resolved
modules/solr/src/main/java/org/testcontainers/containers/SolrClientUtils.java
Outdated
Show resolved
Hide resolved
modules/solr/src/test/java/org/testcontainers/containers/SolrContainerTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard North <rich.north@gmail.com>
Co-authored-by: Richard North <rich.north@gmail.com>
* Replaced localhost with containerIp * Use codeinclude fpr documentation * Ensure http response is closed * Raise exception if core creation fails * Remove author annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @raynigon! This looks good to me, so I'm happy to approve. Thank you for the contribution and thanks for your patience!
Fixes #1562
The Goal is to add support for Apache Solr.
Checklist
Default docker image
Module dependencies
API (e.g. MyModuleContainer class)
Documentation