Add support for https://docs.docker.com/compose/extends/ #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great idea - nice! I'll review tonight. |
| addEnv("COMPOSE_FILE", pwd + "/" + composeFile.getAbsoluteFile().getName()); | ||
| File dockerComposeMainFile = composeFiles.get(0); | ||
| final String pwd = dockerComposeMainFile.getAbsoluteFile().getParentFile().getAbsolutePath(); | ||
| List<String> absoluteDockerComposeFiles = composeFiles.stream().map(file -> pwd + "/" + file.getAbsoluteFile().getName()).collect(Collectors.toList()); |
There was a problem hiding this comment.
Please could you use File.separator rather than "/", just in case?
There was a problem hiding this comment.
The benefit of "/" is that it works both on windows and unix like systems. This why used it instead of File.separator
|
Please could we also have some tests to ensure this is working? |
|
Sure I will add some tests and will trigger again. |
|
@sourcecase did you have a chance to create some tests for this yet? |
|
Hi Richard, |
|
I created a new pull request for the same feature from a different branch including tests: #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass more then one docker-compose file to the docker-compose comand as decribed here https://docs.docker.com/compose/extends/
To make this feature available in testcontainers a list of docker-compose files ahs to be passed to DockerComposeContainer.
The files have to be concatenated in the COMPOSE_FILE env variable as described here https://docs.docker.com/compose/reference/envvars/