Update to docker-java 3.2.0 #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle # core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
bsideup
added
area/shading
type/dependency update
dependencies
# Conflicts: # core/src/main/java/org/testcontainers/dockerclient/DockerClientConfigUtils.java # core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rnorth
reviewed
Mar 5, 2020
| @@ -520,12 +520,12 @@ void checksumFile(File file, Checksum checksum) { | |||
| @SneakyThrows(JsonProcessingException.class) | |||
| final String hash(CreateContainerCmd createCommand) { | |||
There was a problem hiding this comment.
Not consequential to the PR, but is there a reason for this method to be package-private? Should it be @VisibleForTesting?
There was a problem hiding this comment.
IIRC the idea was to make it protected at some point, but I don't really remember anymore 😅
rnorth
approved these changes
Mar 5, 2020
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kiview
approved these changes
Mar 12, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
* Test new `docker-java` module * global Jitpack repo * update to the current master of docker-java * try docker-java-core * use 3.2.0-rc1 * update to docker-java 3.2.0-rc2 * remove unnecessary dependency * Update to docker-java 3.2.0-rc3, use their okhttp cmd factory * post-merge fixes * Update to docker-java 3.2.0-rc4 * fix JarFileShadingTest * Add japicmp task * Update to 3.2.0-rc5 * postpone shading changes * reduce the changeset * do not run japicmp on Windows * try running modules' tests without the checks * split module runs * fix the tasks list * fix the tasks list (2) * do not disable the checks * try `postCheckCommand` * make `postCheckCommand` optional * Update azure-pipelines.yml * Update to docker-java 3.2.0 * restore `postCheckCommand`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.