-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show port mappings in HttpWaitStrategy #2341
Conversation
core/src/main/java/org/testcontainers/containers/wait/strategy/HttpWaitStrategy.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/wait/strategy/HttpWaitStrategy.java
Outdated
Show resolved
Hide resolved
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
I'll pick this up. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
Currently if an HttpWaitStrategy is used, we see an INFO level message like this:
(Where port
32123
is a randomly assigned mapped port)It would be helpful if this log message also showed the original port number as well so we knew what port we were effectively waiting on like this: